Skip to content

Commit

Permalink
resampled video inputs
Browse files Browse the repository at this point in the history
  • Loading branch information
unixpickle committed Aug 13, 2020
1 parent fc32034 commit 7392d0d
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 7 deletions.
35 changes: 29 additions & 6 deletions video_reader.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package ffmpego

import (
"fmt"
"image"
"image/color"
"io"
Expand All @@ -18,29 +19,51 @@ type VideoReader struct {
}

func NewVideoReader(path string) (*VideoReader, error) {
vr, err := newVideoReader(path)
vr, err := newVideoReader(path, -1)
if err != nil {
err = errors.Wrap(err, "read video")
}
return vr, err
}

func newVideoReader(path string) (*VideoReader, error) {
// NewVideoReaderResampled creates a VideoReader that
// automatically changes the input frame rate.
func NewVideoReaderResampled(path string, fps float64) (*VideoReader, error) {
if fps <= 0 {
panic("FPS must be positive")
}
vr, err := newVideoReader(path, fps)
if err != nil {
err = errors.Wrap(err, "read video")
}
return vr, err
}

func newVideoReader(path string, resampleFPS float64) (*VideoReader, error) {
info, err := GetVideoInfo(path)
if err != nil {
return nil, err
}

if resampleFPS > 0 {
info.FPS = resampleFPS
}

inPipe, childPipe, err := os.Pipe()
if err != nil {
return nil, err
}
cmd := exec.Command(
"ffmpeg",

args := []string{
"-i", path,
"-f", "rawvideo", "-pix_fmt", "rgb24",
"pipe:3",
)
}
if resampleFPS > 0 {
args = append(args, "-filter:v", fmt.Sprintf("fps=fps=%f", resampleFPS))
}
args = append(args, "pipe:3")

cmd := exec.Command("ffmpeg", args...)
cmd.ExtraFiles = []*os.File{childPipe}
if err := cmd.Start(); err != nil {
inPipe.Close()
Expand Down
14 changes: 13 additions & 1 deletion video_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,19 @@ func TestVideoReader(t *testing.T) {
t.Fatal(err)
}
defer reader.Close()
testVideoReader(t, reader, 24)
}

func TestVideoReaderResampled(t *testing.T) {
reader, err := NewVideoReaderResampled(filepath.Join("test_data", "test_video.mp4"), 20)
if err != nil {
t.Fatal(err)
}
defer reader.Close()
testVideoReader(t, reader, 40)
}

func testVideoReader(t *testing.T, reader *VideoReader, expectedFrames int) {
numFrames := 0
for {
frame, err := reader.ReadFrame()
Expand All @@ -26,7 +38,7 @@ func TestVideoReader(t *testing.T) {
t.Error("bad video bounds:", frame.Bounds())
}
}
if numFrames != 24 {
if numFrames != expectedFrames {
t.Errorf("incorrect number of frames: %d", numFrames)
}
}

0 comments on commit 7392d0d

Please sign in to comment.