Validating metrics are available for table/column.

unstoppable-allensun · Jul 1, 2024 · 8655f51 · 8655f51
1 parent cc246b3
commit 8655f51
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/macros/edr/data_monitoring/monitors/monitors.sql b/macros/edr/data_monitoring/monitors/monitors.sql
@@ -17,3 +17,17 @@
       'column_boolean': ['count_true', 'count_false']
     }) %}
 {% endmacro %}
+
+{% macro get_available_table_monitors() %}
+    {% do return(elementary.get_available_monitors()["table"]) %}
+{% endmacro %}
+
+{% macro get_available_column_monitors() %}
+    {% set available_col_monitors = [] %}
+    {% for monitor_type, monitors in elementary.get_available_monitors().items() %}
+        {% if monitor_type.startswith("column") %}
+            {% do available_col_monitors.extend(monitors) %}
+        {% endif %}
+    {% endfor %}
+    {% do return(available_col_monitors) %}
+{% endmacro %}
diff --git a/macros/edr/tests/test_collect_metrics.sql b/macros/edr/tests/test_collect_metrics.sql
@@ -29,10 +29,20 @@
         {% do exceptions.raise_compiler_error("Unsupported model: " ~ model ~ " (this might happen if you override 'ref' or 'source')") %}
     {% endif %}
 
+    {% set available_table_monitors = elementary.get_available_table_monitors() %}
+    {% set available_col_monitors = elementary.get_available_column_monitors() %}
+
     {% set table_metrics = [] %}
     {% set col_to_metrics = {} %}
     {% for metric in metrics %}
         {% if metric.get("columns") %}
+            {% if metric.name not in available_col_monitors %}
+                {% if metric.name in available_table_monitors %}
+                    {% do exceptions.raise_compiler_error("The metric '{}' is a table metric and shouldn't receive 'columns' argument.".format(metric.name)) %}
+                {% endif %}
+                {% do exceptions.raise_compiler_error("Unsupported column metric: '{}'.".format(metric.name)) %}
+            {% endif %}
+
             {% if metric.columns is string %}
                 {% if metric.columns == "*" %}
                     {% set columns = adapter.get_columns_in_relation(model_relation) %}
@@ -50,6 +60,13 @@
                 {% do exceptions.raise_compiler_error("Unexpected value provided for 'columns' argument.") %}
             {% endif %}
         {% else %}
+            {% if metric.name not in available_table_monitors %}
+                {% if metric.name in available_col_monitors %}
+                    {% do exceptions.raise_compiler_error("The metric '{}' is a column metric and should receive 'columns' argument.".format(metric.name)) %}
+                {% endif %}
+                {% do exceptions.raise_compiler_error("Unsupported table metric: '{}'.".format(metric.name)) %}
+            {% endif %}
+
             {% do table_metrics.append(metric) %}
         {% endif %}
     {% endfor %}