Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add the support for structured annotations #13

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

AlexisMontagne
Copy link
Member

Thrift annotations on thrift files, yes you heard it right.

This is the successor of #12 that is a generalization. Instead of modifying the thrift AST everytime we want to add a side concept to the type / service definition this PR is here to generalize this concept.

This allows to add annotation (thrift struct) over:

  • types
  • services
  • fields
  • methods.

That can be consumed by either:

  • the compiler directly for codegen (i have some side project of a plugin system).
  • the runtime (most likely at framework level) using reflection ( you can see the utilisation in go & rb)

@AlexisMontagne AlexisMontagne marked this pull request as ready for review October 9, 2024 23:05
@AlexisMontagne AlexisMontagne merged commit 299effb into master Oct 10, 2024
5 checks passed
@AlexisMontagne AlexisMontagne deleted the am/structured-annotations branch October 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants