Cолодовникова Екатерина #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍅 Пройдено тестов 9 из 16 |
mokhov
requested changes
Oct 30, 2017
.vscode/launch.json
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
| // Используйте IntelliSense, чтобы узнать о возможных атрибутах. | |||
robbery.js
Outdated
| exports.isStar = true; | ||
| exports.isStar = false; | ||
| const DayShift = { | ||
| 'ПН': 'ВТ', |
robbery.js
Outdated
| @@ -4,7 +4,16 @@ | |||
| * Сделано задание на звездочку | |||
| * Реализовано оба метода и tryLater | |||
| */ | |||
| exports.isStar = true; | |||
| exports.isStar = false; | |||
| const DayShift = { | |||
There was a problem hiding this comment.
Обычно с большой буквы именуются классы, а не объекты
robbery.js
Outdated
| * @param {Number} timezone | ||
| * @returns {Object} | ||
| */ | ||
| function evenSchedule(schedule, timezone) { |
robbery.js
Outdated
| * @param {Number} timezone | ||
| * @returns {Object} | ||
| */ | ||
| function changeRecord(date, timezone) { |
| return date; | ||
| } | ||
| let rawDateFrom = parseDate(date.from); | ||
| // ['ПН','12','00','5'] |
There was a problem hiding this comment.
Смотри, вот даже то что ты комментарием пишешь результат операции говорит о том, что этот код спустя неделю будет сложно отлазивать. Как можно было бы назвать функцию parseDate, чтобы не запоминать что там будет?
robbery.js
Outdated
| */ | ||
| function parseDate(date) { | ||
| // 'ПН 09:00+3' | ||
| let day = date.split(':')[0].split(' ')[0]; |
There was a problem hiding this comment.
date.split(:) можно было бы сохранить в переменную, чтобы не делать каждый раз .split
robbery.js
Outdated
| let newHour = hours + shift; | ||
| if (newHour > 24) { | ||
| switch (rawDate[0]) { | ||
| case 'ПН': |
There was a problem hiding this comment.
Кажется для чего-то такого у тебя есть странный объект DayShift выше
robbery.js
Outdated
| let timezone = getTimeZone(workingHours); | ||
| schedule = evenSchedule(schedule, timezone); | ||
| schedule = cutSchedule(schedule); | ||
| schedule = convertScheduleToMinutes (schedule); |
|
🍅 Пройдено тестов 9 из 16 |
|
Пройденных тестов стало меньше |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.