Имаев Альберт #20
Closed
Имаев Альберт #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍏 Пройден линтинг и базовые тесты |
nex2hex
requested changes
Apr 25, 2018
queries.js
Outdated
| } | ||
|
|
||
| getCheapSouvenirs(price) { | ||
| // Данный метод должен возвращать все сувениры, цена которых меньше или равна price. | ||
| return this.Souvenir.findAll({ | ||
| where: { | ||
| price: { [this.Op.lt]: price } |
| primaryKey: true, | ||
| autoIncrement: true | ||
| }, | ||
| name: { |
There was a problem hiding this comment.
кажется, что тут нужен индекс (в коде есть выборка по тэгу)
| autoIncrement: true | ||
| }, | ||
| login: { | ||
| type: DataTypes.TEXT |
There was a problem hiding this comment.
и тут индекс, уникальный (не может быть двух юзеров с одинаковым логином)
queries.js
Outdated
| attributes: ['id', 'name', 'image', 'price', 'rating'], | ||
| include: { | ||
| model: this.Tag, | ||
| where: { name: tag }, |
There was a problem hiding this comment.
сравнение лучше делать регистронезависимым
queries.js
Outdated
| }, | ||
| include: [{ | ||
| model: this.Country, | ||
| where: { name: country }, |
| await souvenir.createReview(review, { transaction }); | ||
|
|
||
| const reviews = await souvenir.getReviews({ transaction }); | ||
| rating = (souvenir.rating * (reviews.length - 1) + rating) / (reviews.length); |
There was a problem hiding this comment.
не обязательно к исправлению
сейчас ты загружаешь в приложение весь список отзывов и обновляешь рейтинг
Такие вычисления лучше делать на стороне БД
queries.js
Outdated
| }, | ||
| { | ||
| model: this.User, | ||
| where: { login } |
There was a problem hiding this comment.
тут тоже лучше регистронезависимое сравнение
|
🍏 Пройден линтинг и базовые тесты |
|
🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.