Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @urql/tanstack-react-router #3729

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schiller-manuel
Copy link

Summary

integration of @tanstack/react-router

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: cae0d95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/tanstack-react-router Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/afraid-colts-sort.md Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/CHANGELOG.md Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/jsr.json Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/jsr.json Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/package.json Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/package.json Outdated Show resolved Hide resolved
},
"main": "dist/urql-tanstack-react-router.js",
"module": "dist/urql-tanstack-react-router.es.js",
"types": "dist/urql-tanstack-react-router.d.ts",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the export mappings, examples in other packages

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was looking at packages/react-urql/package.json which also does not have export mappings.
Why do we need export mappings here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React-urql is a special case due to some old frameworks, vite is a good bundler so we should incorporate export mappings to future proof the package. What we do with react-urql is still a bit of a pickle, especially with regards to react-native

packages/tanstack-react-router-urql/package.json Outdated Show resolved Hide resolved
packages/tanstack-react-router-urql/src/useUrqlValue.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants