-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @urql/tanstack-react-router #3729
base: main
Are you sure you want to change the base?
feat: add @urql/tanstack-react-router #3729
Conversation
🦋 Changeset detectedLatest commit: cae0d95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
892648c
to
cae0d95
Compare
}, | ||
"main": "dist/urql-tanstack-react-router.js", | ||
"module": "dist/urql-tanstack-react-router.es.js", | ||
"types": "dist/urql-tanstack-react-router.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the export mappings, examples in other packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was looking at packages/react-urql/package.json
which also does not have export mappings.
Why do we need export mappings here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React-urql is a special case due to some old frameworks, vite is a good bundler so we should incorporate export mappings to future proof the package. What we do with react-urql is still a bit of a pickle, especially with regards to react-native
Summary
integration of @tanstack/react-router