1362 editable post dates #1440
Merged
1362 editable post dates #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmackay
suggested changes
Oct 14, 2016
| @@ -79,6 +80,7 @@ protected function getDefinition() | |||
| 'status' => 'string', | |||
| 'created' => 'int', | |||
| 'updated' => 'int', | |||
| 'post_date' => 'string', | |||
There was a problem hiding this comment.
We can use *timestamp here and it should run the value through strtotime
| @@ -818,6 +818,10 @@ public function create(Entity $entity) | |||
|
|
|||
| // Remove attribute values and tags | |||
| unset($post['values'], $post['tags'], $post['completed_stages'], $post['sets'], $post['source'], $post['color']); | |||
| // Convert post_date to mysql format | |||
| if(array_key_exists('post_date', $post)) { | |||
| $post['post_date'] = date("Y-m-d H:i:s", strtotime($post['post_date'])); | |||
There was a problem hiding this comment.
This should happen on the entity so its in a consistent format there
| @@ -61,7 +61,7 @@ class PostAuthorizer implements Authorizer, Permissionable | |||
| */ | |||
| protected function getAllPrivs() | |||
| { | |||
| return ['read', 'create', 'update', 'delete', 'search', 'change_status']; | |||
| return ['read', 'create', 'update', 'delete', 'search', 'change_status', 'change_timestamp']; | |||
There was a problem hiding this comment.
Don't need this change_timestamp isn't a separate permission, just part of update
rjmackay
reviewed
Oct 14, 2016
| ->addColumn('post_date', 'datetime', [ | ||
| 'null' => true, | ||
| ]) | ||
| ->update(); |
There was a problem hiding this comment.
Need to populate this for all existing posts too
There was a problem hiding this comment.
How do you mean? As in a value default?
rjmackay
approved these changes
Oct 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test these changes by:
Fixes #1362
Ping @ushahidi/platform
This change is