Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Single click to open resource #765

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

henrychoy
Copy link
Collaborator

Closes issue #709

Single click to open resource. Also added delete button on each table row.

@henrychoy henrychoy self-assigned this Feb 18, 2025
Copy link
Collaborator

@keithmanville keithmanville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me and I think meets the definition of done in the issue card.

When viewing history, can we make it so the delete button is disabled (just like the submit button and edit fields)? It might not be clear to the user they would be deleting the whole resource and not a specific snapshot and would make it consistent with disabling any modifications when viewing history.

Also, curious to see what you think about using a different color for the cancel button to make it more distinct from deletion.

@henrychoy
Copy link
Collaborator Author

Overall looks good to me and I think meets the definition of done in the issue card.

When viewing history, can we make it so the delete button is disabled (just like the submit button and edit fields)? It might not be clear to the user they would be deleting the whole resource and not a specific snapshot and would make it consistent with disabling any modifications when viewing history.

Also, curious to see what you think about using a different color for the cancel button to make it more distinct from deletion.

Just updated to make the delete button disabled when viewing history. I can do the same when I add history to the rest of the pages. Also I made all cancel buttons more neutral looking so that the delete buttons stand out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants