Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter generator XSLT: fix reference to attribute, _key-name #83

Merged

Conversation

galtm
Copy link
Collaborator

@galtm galtm commented Nov 20, 2023

Committer Notes

Closes #82

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@galtm galtm requested a review from a team as a code owner November 20, 2023 18:27
@galtm galtm changed the title Converter XSLT: fix reference to attribute, _key-name Converter generator XSLT: fix reference to attribute, _key-name Nov 20, 2023
@galtm galtm force-pushed the attrname-produce-xml-converter branch from 425f59a to 2949722 Compare March 8, 2024 22:23
Copy link

github-actions bot commented Mar 8, 2024

XSpec Test Results

  2 files  ±0  40 suites  ±0   0s ⏱️ ±0s
105 tests ±0  90 ✅ ±0  15 💤 ±0  0 ❌ ±0 
114 runs  ±0  99 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 2949722. ± Comparison against base commit 0010340.

@galtm
Copy link
Collaborator Author

galtm commented Mar 8, 2024

I rebased my commit off the develop branch and force-pushed, to refresh this pull request. The checks ran and all passed.

@wendellpiez wendellpiez merged commit 04a4a4c into usnistgov:develop Jun 4, 2024
3 checks passed
@galtm galtm deleted the attrname-produce-xml-converter branch June 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converter generator XSLT has probable typo in an attribute name
3 participants