fix(darwin): stop method should return path only after completed reco…

…rding.
usseiin · Oct 5, 2023 · 26edb8f · 26edb8f
1 parent 91222bd
commit 26edb8f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/record/example/ios/Podfile.lock b/record/example/ios/Podfile.lock
@@ -28,9 +28,9 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   audioplayers_darwin: 877d9a4d06331c5c374595e46e16453ac7eafa40
   Flutter: f04841e97a9d0b0a8025694d0796dd46242b2854
-  path_provider_foundation: eaf5b3e458fc0e5fbb9940fb09980e853fe058b8
+  path_provider_foundation: 29f094ae23ebbca9d3d0cec13889cd9060c0e943
   record_darwin: 1f6619f2abac4d1ca91d3eeab038c980d76f1517
 
 PODFILE CHECKSUM: 7368163408c647b7eb699d0d788ba6718e18fb8d
 
-COCOAPODS: 1.12.1
+COCOAPODS: 1.13.0
diff --git a/record_darwin/CHANGELOG.md b/record_darwin/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.0.0-beta.2+4
+* fix: reflect stop changes on iOS code.
+
 ## 1.0.0-beta.2+3
 * fix: stop method should return path only after completed recording.
 * fix: Send stream event on main thread.

diff --git a/record_darwin/ios/Classes/RecorderIOS.swift b/record_darwin/ios/Classes/RecorderIOS.swift
@@ -56,7 +56,7 @@ extension Recorder {
         if options.contains(.shouldResume) {
           resume()
         } else {
-          _ = stop()
+          stop(completionHandler: {(path) -> () in })
         }
       }
     }

diff --git a/record_darwin/pubspec.yaml b/record_darwin/pubspec.yaml
@@ -1,6 +1,6 @@
 name: record_darwin
 description: iOS and macOS implementations for record package called by record_platform_interface.
-version: 1.0.0-beta.2+3
+version: 1.0.0-beta.2+4
 homepage: https://github.com/llfbandit/record/tree/master/record_darwin
 
 environment: