Skip to content

Commit

Permalink
QUIC: optimized ACK delay.
Browse files Browse the repository at this point in the history
Previously ACK was not generated if max_ack_delay was not yet expired and the
number of unacknowledged ack-eliciting packets was less than two, as allowed by
RFC 9000 13.2.1-13.2.2.  However this only makes sense to avoid sending ACK-only
packets, as explained by the RFC:

  On the other hand, reducing the frequency of packets that carry only
  acknowledgments reduces packet transmission and processing cost at both
  endpoints.

Now ACK is delayed only if output frame queue is empty.  Otherwise ACK is sent
immediately, which significantly improves QUIC performance with certain tests.
  • Loading branch information
arut committed Jul 27, 2023
1 parent bdea5b7 commit 6e60e21
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/event/quic/ngx_event_quic_ack.c
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,8 @@ ngx_quic_generate_ack(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx)
delay = ngx_current_msec - ctx->ack_delay_start;
qc = ngx_quic_get_connection(c);

if (ctx->send_ack < NGX_QUIC_MAX_ACK_GAP
if (ngx_queue_empty(&ctx->frames)
&& ctx->send_ack < NGX_QUIC_MAX_ACK_GAP
&& delay < qc->tp.max_ack_delay)
{
if (!qc->push.timer_set && !qc->closing) {
Expand Down

0 comments on commit 6e60e21

Please sign in to comment.