fix(Select): crash when mode=tag&&value={null}&&isPreview, close alib…

…aba-fusion#2175
v5zz · Sep 17, 2020 · bcc4ddc · bcc4ddc
1 parent e334c41
commit bcc4ddc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/select/base.jsx b/src/select/base.jsx
@@ -651,7 +651,7 @@ export default class Base extends React.Component {
                                 style={style}
                                 className={className}
                                 isPreview={isPreview}
-                                value={fillProps ? valueDS[fillProps] : valueDS && valueDS.label}
+                                value={valueDS ? (fillProps ? valueDS[fillProps] : valueDS.label) : ''}
                             />
                         );
                     } else {
@@ -660,7 +660,7 @@ export default class Base extends React.Component {
                                 style={style}
                                 className={className}
                                 isPreview={isPreview}
-                                value={valueDS.map(i => i.label).join(', ')}
+                                value={(valueDS || []).map(i => i.label).join(', ')}
                             />
                         );
                     }

diff --git a/test/select/index-spec.js b/test/select/index-spec.js
@@ -338,6 +338,19 @@ describe('Select', () => {
         assert(wrapper.getDOMNode().innerText === '');
     });
 
+    it('should renderPreview mode="tag"', () => {
+        const wrapper = mount(
+            <Select
+                isPreview
+                mode="tag"
+                dataSource={[]}
+                value={null}
+            />
+        );
+
+        assert(wrapper.getDOMNode().innerText === '');
+    });
+
     it('should support children null', () => {
         wrapper.setProps({
             children: [