Remove unused Writable::create() function #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make this a |
|
Sure! Great idea! |
|
@vE5li After having looked intot he code: Where do we use this anyhow? I can't find any usage of the create function in the code, so putting it behind "patched_as_folder" seems odd right now. |
|
Huh.. I was sure it's used in the gamefile loader when creating the patched lua files but I can't find it either (I'm on mobile so take that with a grain of salt). Maybe it's not used anymore. |
|
We use "create_dir_all" in the "add_file" also, so it seems we don't need a dedicated logic to create the whole folder structure anymore. I will remove the function for now. |
The functionality isn't used anymore, since the add_file() function will call create_dir_all() if not all folders are found.
hasenbanck
force-pushed
the
allow_unused_writable
branch
from
cdb32d2 to
ed0ad29
Compare
hasenbanck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality isn't used anymore, since the add_file() function will call create_dir_all() if not all folders are found.