Skip to content

Commit

Permalink
Fix win build
Browse files Browse the repository at this point in the history
Summary: Fixing error with win build where we compare int64_t with size_t.

Test Plan: make check

Reviewers: andrewkr

Reviewed By: andrewkr

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D57885
  • Loading branch information
Yi Wu committed May 9, 2016
1 parent 6504c31 commit 0645e8b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions db/db_iterator_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1566,7 +1566,7 @@ TEST_F(DBIteratorTest, ReadAhead) {
auto* iter = db_->NewIterator(read_options);
iter->SeekToFirst();
int64_t num_file_opens = TestGetTickerCount(options, NO_FILE_OPENS);
int64_t bytes_read = env_->random_read_bytes_counter_;
size_t bytes_read = env_->random_read_bytes_counter_;
delete iter;

env_->random_read_bytes_counter_ = 0;
Expand All @@ -1575,7 +1575,7 @@ TEST_F(DBIteratorTest, ReadAhead) {
iter = db_->NewIterator(read_options);
iter->SeekToFirst();
int64_t num_file_opens_readahead = TestGetTickerCount(options, NO_FILE_OPENS);
int64_t bytes_read_readahead = env_->random_read_bytes_counter_;
size_t bytes_read_readahead = env_->random_read_bytes_counter_;
delete iter;
ASSERT_EQ(num_file_opens + 3, num_file_opens_readahead);
ASSERT_GT(bytes_read_readahead, bytes_read);
Expand Down
6 changes: 3 additions & 3 deletions db/db_test_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ class SpecialEnv : public EnvWrapper {
public:
CountingFile(unique_ptr<RandomAccessFile>&& target,
anon::AtomicCounter* counter,
std::atomic<int64_t>* bytes_read)
std::atomic<size_t>* bytes_read)
: target_(std::move(target)),
counter_(counter),
bytes_read_(bytes_read) {}
Expand All @@ -374,7 +374,7 @@ class SpecialEnv : public EnvWrapper {
private:
unique_ptr<RandomAccessFile> target_;
anon::AtomicCounter* counter_;
std::atomic<int64_t>* bytes_read_;
std::atomic<size_t>* bytes_read_;
};

Status s = target()->NewRandomAccessFile(f, r, soptions);
Expand Down Expand Up @@ -471,7 +471,7 @@ class SpecialEnv : public EnvWrapper {

bool count_random_reads_;
anon::AtomicCounter random_read_counter_;
std::atomic<int64_t> random_read_bytes_counter_;
std::atomic<size_t> random_read_bytes_counter_;
std::atomic<int> random_file_open_counter_;

bool count_sequential_reads_;
Expand Down

0 comments on commit 0645e8b

Please sign in to comment.