Skip to content

merge_pr_16629

merge_pr_16629: Always use physical coordinates for visual rects
@wangxianzhu wangxianzhu tagged this 02 May 17:15 
- Let MapToVisualRectInAncestorSpace() always treat the input rect as
  in pure physical coordinates. Previously the input was inconsistent:
  pure physical for boxes, and flipped for inlines.

- This makes it clear that all visual rects, regardless of their
  coordinates spaces, are in physical coordinates.

- This reduces unnecessary back and forth flipping in LayoutNG which
  is already using physical coordinates in inline layout.

Bug: 941228
Change-Id: I10e16c5e7833e94a615e4dd18aa3141512b8e9e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568619
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#656051}
Assets 2
Loading