Skip to content

merge_pr_28338

merge_pr_28338: WebLocks: Remove invalid DCHECK and add some comments.
@mkruisselbrink mkruisselbrink tagged this 01 Apr 20:03 
It is possible for a ExecutionContext to be destroyed, and all its locks
to be released while the lock is still being set up. Remove a DCHECK
that tried to verify that this didn't happen. All the relevant code
should work correctly even if Lock::handle_ does become unbound.

If the handle_ gets unbound because the ExecutionContext is destroyed
Lock might not signal LockManager that it is no longer held and thus can
be destroyed, but that is okay, as LockManager itself will clear out all
references to Lock objects when the ExecutionContext is destroyed
anyway.

Bug: 1190515
Change-Id: Idbb6014cbd7f18257fdf3f7a2dffa7f7aeae75c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783622
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#868622}
Assets 2
Loading