Skip to content

merge_pr_29998

merge_pr_29998: Break floats inside self-collapsing blocks correctly.
@mstensho mstensho tagged this 11 Aug 21:59 
Even if the BFC block-offset is unknown when finishing layout of a block
(this can happen if the block is self-collapsing), we still need to
FinalizeForFragmentation(), in order to detect any breaks inside child
floats, so that the break gets propagated correctly. If the initial
optimistic BFC block-offset guess was correct, we won't lay out again
with a forced block-offset identical to the optimistic one. So this is
our only chance.

Just use the "expected" block-offset if there's no BFC block-offset set.

Among the new tests, only float-in-self-collapsing-block-000.html were
failing without this, but I also added another test to verify that we
don't get stuck with an incorrect optimistic guess.

Bug: 1238508
Change-Id: Id70a4fc9a897ade0801dc1993742d2ba14209ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3087457
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#910990}
Assets 2
Loading