Skip to content

merge_pr_9507

merge_pr_9507: [css-typed-om] Refactor the per-property test harness.
@darrnshn darrnshn tagged this 14 Feb 02:26 
This patch refactors the per-property test harness quite
a bit to deal with property specific behaviour:

- We allow tests to override the expectation/asserts
  for specified and computed values. So it means that a
  property might compute 'auto' to '0px' and we can easily
  assert that by passing a callback to 'computed'.

- We moved margin-top to margin and test all the margin
  properties (except the margin shorthand).

- We made margin properties work by setting the correct
  metadata in the CSSProperties.json5.

- We removed unitless zero tests. They don't seem to
  be required by the spec.

Bug: 774887
Change-Id: I08605ac6af01576ff9f6c878c2ca9e280c9948e1
Reviewed-on: https://chromium-review.googlesource.com/915884
Reviewed-by: nainar <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#536603}
Assets 2
Loading