MDL-48823 admin: Just one admin tree reload after settings changes

valmynd · Jan 21, 2015 · 8babb96 · 8babb96
1 parent da0ef2e
commit 8babb96
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 5 deletions.
diff --git a/admin/category.php b/admin/category.php
@@ -67,7 +67,6 @@
         $errormsg = get_string('errorwithsettings', 'admin');
         $firsterror = reset($adminroot->errors);
     }
-    $adminroot = admin_get_root(true); //reload tree
     $settingspage = $adminroot->locate($category, true);
 }
 
@@ -156,4 +155,4 @@
 echo html_writer::end_tag('fieldset');
 echo html_writer::end_tag('form');
 
-echo $OUTPUT->footer();
+echo $OUTPUT->footer();
diff --git a/admin/search.php b/admin/search.php
@@ -22,7 +22,6 @@
     if (admin_write_settings($data)) {
         $statusmsg = get_string('changessaved');
     }
-    $adminroot = admin_get_root(true); //reload tree
 
     if (!empty($adminroot->errors)) {
         $errormsg = get_string('errorwithsettings', 'admin');

diff --git a/admin/settings.php b/admin/settings.php
@@ -48,7 +48,6 @@
         $errormsg = get_string('errorwithsettings', 'admin');
         $firsterror = reset($adminroot->errors);
     }
-    $adminroot = admin_get_root(true); //reload tree
     $settingspage = $adminroot->locate($section, true);
 }
 

diff --git a/admin/upgradesettings.php b/admin/upgradesettings.php
@@ -24,7 +24,6 @@
 // now we'll deal with the case that the admin has submitted the form with new settings
 if ($data = data_submitted() and confirm_sesskey()) {
     $count = admin_write_settings($data);
-    $adminroot = admin_get_root(true); //reload tree
 }
 
 $newsettings = admin_output_new_settings_by_page($adminroot);