Volod/eng 2733 avoid dlp validator crashes eg if rpc goes down 2 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
volod-vana
commented
Jul 12, 2024
volod-vana
commented
…xceptions that might occur, allow for keyboard interruption
volod-vana
requested review from
Kahtaf and
tnunamak
and removed request for
Kahtaf
tnunamak
approved these changes
Jul 12, 2024
Kahtaf
approved these changes
Jul 12, 2024
chatgpt/nodes/validator.py
Outdated
| vana.logging.error(f"An error occurred: {str(e)}") | ||
| vana.logging.error("Restarting the validator in 30 seconds...") | ||
| asyncio.sleep(30) | ||
| except KeyboardInterrupt: |
There was a problem hiding this comment.
Should we shut down the KeyboardInterrupt more gracefully like here? Maybe we can even get rid of the KeyboardInterrupt there.
There was a problem hiding this comment.
Good catch, I removed KeyboardInterrupt from the if __name__ == "__main__" section, one in run method works properly, no need to duplicate that.
I also change it a little bit to move initialization inside while loop, this cover the case when validatior starts for the first time with broken RPC / network issues.
volod-vana
deleted the
volod/eng-2733-avoid-dlp-validator-crashes-eg-if-rpc-goes-down-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.