Remove useless matches variable istitle method

vanjaw · Oct 27, 2017 · 859637f · 859637f
1 parent c4c2495
commit 859637f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/python/common/org/python/types/Bytes.java b/python/common/org/python/types/Bytes.java
@@ -1082,11 +1082,11 @@ public org.python.Object istitle() {
             return new org.python.types.Bool(false);
         }
 
-        boolean matches = Arrays.equals(this.value, _title(this.value));
-
-        for (int idx = 0; idx < this.value.length; ++idx) {
-            if (_isalpha(this.value[idx]) && matches) {
-                return new org.python.types.Bool(true);
+        if (Arrays.equals(this.value, _title(this.value))) {
+            for (int idx = 0; idx < this.value.length; ++idx) {
+                if (_isalpha(this.value[idx])) {
+                    return new org.python.types.Bool(true);
+                }
             }
         }
 

diff --git a/python/common/org/python/types/Str.java b/python/common/org/python/types/Str.java
@@ -973,13 +973,14 @@ public org.python.Object istitle() {
             return new org.python.types.Bool(false);
         }
 
-        boolean matches = this.value.equals(_title(this.value));
-
-        for (int idx = 0; idx < this.value.length(); idx++) {
-            if (Character.isLetter(this.value.charAt(idx)) && matches) {
-                return new org.python.types.Bool(true);
+        if (this.value.equals(_title(this.value))) {
+            for (int idx = 0; idx < this.value.length(); idx++) {
+                if (Character.isLetter(this.value.charAt(idx))) {
+                    return new org.python.types.Bool(true);
+                }
             }
         }
+
         return new org.python.types.Bool(false);
     }