Fix ability to use long b'' literals

The BIPUSH opcode treats values as 8-bit signed, and sign-extends when
storing.  Using BIPUSH to set the length of a byte array limits the
length to 127 bytes.

Use ICONST_val instead of BIPUSH to select the appropriate instruction
for setting the length of a byte array.  Also, only pass values in the
8-bit signed range to BIPUSH.

tests/datatypes/test_bytes.py

@@ -601,6 +601,14 @@ def test_too_many_arguments(self):
                 print(err)
         """)
 
+    def test_long_literal(self):
+        self.assertCodeExecution("""
+            b = b'''00000000001111111111222222222233333333334444444444
+            55555555556666666666777777777888888888899999999990000000000
+            11111111112222222222'''
+            print(b)
+        """)
+
 
 class UnaryBytesOperationTests(UnaryOperationTestCase, TranspileTestCase):
     data_type = 'bytes'

voc/java/opcodes.py

@@ -463,11 +463,11 @@ def __arg_repr__(self):
 
     @classmethod
     def read_extra(cls, reader, dump=None):
-        const = reader.read_u1()
+        const = reader.read_s1()
         return cls(const)
 
     def write_extra(self, writer):
-        writer.write_u1(self.const)
+        writer.write_s1(self.const)
 
     @property
     def produce_count(self):

voc/python/ast.py

@@ -2260,15 +2260,16 @@ def visit_Bytes(self, node):
         self.context.add_opcodes(
             java.New('org/python/types/Bytes'),
 
-            JavaOpcodes.BIPUSH(len(node.s)),
+            ICONST_val(len(node.s)),
             JavaOpcodes.NEWARRAY(JavaOpcodes.NEWARRAY.T_BYTE),
         )
 
         for i, b in enumerate(node.s):
             self.context.add_opcodes(
                 JavaOpcodes.DUP(),
                 ICONST_val(i),
-                JavaOpcodes.BIPUSH(node.s[i]),
+                # 'bytes' values are unsigned, but BIPUSH needs signed values
+                JavaOpcodes.BIPUSH(b if b <= 127 else b - 256),
                 JavaOpcodes.BASTORE(),
             )
 

voc/python/types/primitives.py

@@ -399,6 +399,8 @@ def ICONST_val(value):
             return JavaOpcodes.ICONST_5()
         elif value == -1:
             return JavaOpcodes.ICONST_M1()
+        elif -128 <= value <= 127:
+            return JavaOpcodes.BIPUSH(value)
         elif -32768 <= value <= 32767:
             return JavaOpcodes.SIPUSH(value)
         elif -2147483648 <= value <= 2147483647: