Skip to content

Commit

Permalink
[Reverb] Fix the build.
Browse files Browse the repository at this point in the history
TF moved to C++17, where absl::string_view is std::string_view; which led
to a bunch of linker errors since we're still building with C++14 mode.

I was able to debug this *only* because I saw Mihai's tweet last week:
  https://twitter.com/mihaimaruseac/status/1528548118576365571

... which makes me inexplicably angry :<E (not at Mihai).
We shouldn't be finding out about breaking changes via twitter.

PiperOrigin-RevId: 452581699
Change-Id: I52024fac3ca44a743dc73de578e0b6ad799a55fe
  • Loading branch information
ebrevdo authored and copybara-github committed Jun 2, 2022
1 parent 717a61f commit 957d5ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ build --python_path=python3
build:manylinux2014 --crosstool_top=//third_party/toolchains/preconfig/ubuntu16.04/gcc7_manylinux2014:toolchain

build -c opt
build --cxxopt="-std=c++14"
build --cxxopt="-std=c++17"
# We can emove this flag (we keep it explicit for now)
build --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=1"
build --auto_output_filter=subpackages
Expand Down

0 comments on commit 957d5ff

Please sign in to comment.