added error checking to linting

vasiigor575 · Oct 8, 2020 · 0b082ef · 0b082ef
1 parent c9955a3
commit 0b082ef
Show file tree

Hide file tree

Showing 62 changed files with 1,737 additions and 768 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -6,6 +6,7 @@ linters:
   enable:
     - bodyclose
     - deadcode
+    - errcheck
     - goconst
     - gocritic
     - gofmt
@@ -19,7 +20,6 @@ linters:
     - nakedret
     - unconvert
     - varcheck
-    # - errcheck
     # - golint
     # - lll
     # - gocyclo

diff --git a/cache/lru_cache_benchmark_test.go b/cache/lru_cache_benchmark_test.go
@@ -1,3 +1,6 @@
+// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
 package cache
 
 import (
@@ -13,7 +16,9 @@ func BenchmarkLRUCachePutSmall(b *testing.B) {
 	for n := 0; n < b.N; n++ {
 		for i := 0; i < smallLen; i++ {
 			var idBytes [32]byte
-			rand.Read(idBytes[:])
+			if _, err := rand.Read(idBytes[:]); err != nil {
+				b.Fatal(err)
+			}
 			cache.Put(ids.NewID(idBytes), n)
 		}
 		b.StopTimer()
@@ -28,7 +33,9 @@ func BenchmarkLRUCachePutMedium(b *testing.B) {
 	for n := 0; n < b.N; n++ {
 		for i := 0; i < mediumLen; i++ {
 			var idBytes [32]byte
-			rand.Read(idBytes[:])
+			if _, err := rand.Read(idBytes[:]); err != nil {
+				b.Fatal(err)
+			}
 			cache.Put(ids.NewID(idBytes), n)
 		}
 		b.StopTimer()
@@ -43,7 +50,9 @@ func BenchmarkLRUCachePutLarge(b *testing.B) {
 	for n := 0; n < b.N; n++ {
 		for i := 0; i < largeLen; i++ {
 			var idBytes [32]byte
-			rand.Read(idBytes[:])
+			if _, err := rand.Read(idBytes[:]); err != nil {
+				b.Fatal(err)
+			}
 			cache.Put(ids.NewID(idBytes), n)
 		}
 		b.StopTimer()

diff --git a/chains/manager.go b/chains/manager.go
@@ -341,12 +341,14 @@ func (m *manager) buildChain(chainParams ChainParameters) (*chain, error) {
 		return nil, fmt.Errorf("the vm should have type avalanche.DAGVM or snowman.ChainVM. Chain not created")
 	}
 
+	// Register the chain with the timeout manager
+	if err := m.TimeoutManager.RegisterChain(ctx, consensusParams.Namespace); err != nil {
+		return nil, err
+	}
+
 	// Allows messages to be routed to the new chain
 	m.ManagerConfig.Router.AddChain(chain.Handler)
 
-	// Register the chain with the timeout manager
-	m.TimeoutManager.RegisterChain(ctx, consensusParams.Namespace)
-
 	// If the X or P Chain panics, do not attempt to recover
 	if m.CriticalChains.Contains(chainParams.ID) {
 		go ctx.Log.RecoverAndPanic(chain.Handler.Dispatch)

diff --git a/ids/aliases_test.go b/ids/aliases_test.go
@@ -1,4 +1,4 @@
-// (c) 2020, Alex Willmer. All rights reserved.
+// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
 package ids
@@ -37,7 +37,9 @@ func TestAliaserLookup(t *testing.T) {
 	id := NewID([32]byte{'K', 'a', 't', 'e', ' ', 'K', 'a', 'n', 'e'})
 	aliaser := Aliaser{}
 	aliaser.Initialize()
-	aliaser.Alias(id, "Batwoman")
+	if err := aliaser.Alias(id, "Batwoman"); err != nil {
+		t.Fatal(err)
+	}
 
 	res, err := aliaser.Lookup("Batwoman")
 	if err != nil {
@@ -63,8 +65,12 @@ func TestAliaserAliases(t *testing.T) {
 	id := NewID([32]byte{'B', 'r', 'u', 'c', 'e', ' ', 'W', 'a', 'y', 'n', 'e'})
 	aliaser := Aliaser{}
 	aliaser.Initialize()
-	aliaser.Alias(id, "Batman")
-	aliaser.Alias(id, "Dark Knight")
+	if err := aliaser.Alias(id, "Batman"); err != nil {
+		t.Fatal(err)
+	}
+	if err := aliaser.Alias(id, "Dark Knight"); err != nil {
+		t.Fatal(err)
+	}
 
 	aliases := aliaser.Aliases(id)
 	expected := []string{"Batman", "Dark Knight"}
@@ -78,8 +84,12 @@ func TestAliaserPrimaryAlias(t *testing.T) {
 	id2 := NewID([32]byte{'B', 'r', 'u', 'c', 'e', ' ', 'W', 'a', 'y', 'n', 'e'})
 	aliaser := Aliaser{}
 	aliaser.Initialize()
-	aliaser.Alias(id2, "Batman")
-	aliaser.Alias(id2, "Dark Knight")
+	if err := aliaser.Alias(id2, "Batman"); err != nil {
+		t.Fatal(err)
+	}
+	if err := aliaser.Alias(id2, "Dark Knight"); err != nil {
+		t.Fatal(err)
+	}
 
 	res, err := aliaser.PrimaryAlias(id1)
 	if res != "" {
@@ -104,7 +114,9 @@ func TestAliaserAliasClash(t *testing.T) {
 	id2 := NewID([32]byte{'D', 'i', 'c', 'k', ' ', 'G', 'r', 'a', 'y', 's', 'o', 'n'})
 	aliaser := Aliaser{}
 	aliaser.Initialize()
-	aliaser.Alias(id1, "Batman")
+	if err := aliaser.Alias(id1, "Batman"); err != nil {
+		t.Fatal(err)
+	}
 
 	err := aliaser.Alias(id2, "Batman")
 	if err == nil {
@@ -117,8 +129,12 @@ func TestAliaserRemoveAlias(t *testing.T) {
 	id2 := NewID([32]byte{'J', 'a', 'm', 'e', 's', ' ', 'G', 'o', 'r', 'd', 'o', 'n'})
 	aliaser := Aliaser{}
 	aliaser.Initialize()
-	aliaser.Alias(id1, "Batman")
-	aliaser.Alias(id1, "Dark Knight")
+	if err := aliaser.Alias(id1, "Batman"); err != nil {
+		t.Fatal(err)
+	}
+	if err := aliaser.Alias(id1, "Dark Knight"); err != nil {
+		t.Fatal(err)
+	}
 
 	aliaser.RemoveAliases(id1)
 

diff --git a/ids/bag_benchmark_test.go b/ids/bag_benchmark_test.go
@@ -1,17 +1,21 @@
+// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
 package ids
 
 import (
 	"crypto/rand"
 	"testing"
 )
 
-//
 func BenchmarkBagListSmall(b *testing.B) {
 	smallLen := 5
 	bag := Bag{}
 	for i := 0; i < smallLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		bag.Add(NewID(idBytes))
 	}
@@ -26,7 +30,9 @@ func BenchmarkBagListMedium(b *testing.B) {
 	bag := Bag{}
 	for i := 0; i < mediumLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		bag.Add(NewID(idBytes))
 	}
@@ -42,7 +48,9 @@ func BenchmarkBagListLarge(b *testing.B) {
 	bag := Bag{}
 	for i := 0; i < largeLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		bag.Add(NewID(idBytes))
 	}

diff --git a/ids/queue_test.go b/ids/queue_test.go
@@ -1,3 +1,6 @@
+// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
 package ids
 
 import (

diff --git a/ids/set_benchmark_test.go b/ids/set_benchmark_test.go
@@ -1,17 +1,21 @@
+// (c) 2019-2020, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+
 package ids
 
 import (
 	"crypto/rand"
 	"testing"
 )
 
-//
 func BenchmarkSetListSmall(b *testing.B) {
 	smallLen := 5
 	set := Set{}
 	for i := 0; i < smallLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		set.Add(NewID(idBytes))
 	}
@@ -26,7 +30,9 @@ func BenchmarkSetListMedium(b *testing.B) {
 	set := Set{}
 	for i := 0; i < mediumLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		set.Add(NewID(idBytes))
 	}
@@ -42,7 +48,9 @@ func BenchmarkSetListLarge(b *testing.B) {
 	set := Set{}
 	for i := 0; i < largeLen; i++ {
 		var idBytes [32]byte
-		rand.Read(idBytes[:])
+		if _, err := rand.Read(idBytes[:]); err != nil {
+			b.Fatal(err)
+		}
 		NewID(idBytes)
 		set.Add(NewID(idBytes))
 	}