Ban require.NotEqualValues (ava-labs#1470)

vasiigor575 · May 6, 2023 · 1b64bbe · 1b64bbe
1 parent 8903335
commit 1b64bbe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -68,6 +68,7 @@ linters-settings:
       - 'require\.Error$(# ErrorIs should be used instead)?'
       - 'require\.ErrorContains$(# ErrorIs should be used instead)?'
       - 'require\.EqualValues$(# Equal should be used instead)?'
+      - 'require\.NotEqualValues$(# NotEqual should be used instead)?'
     exclude_godoc_examples: false
   # https://golangci-lint.run/usage/linters#gosec
   gosec:

diff --git a/network/peer/ip_signer_test.go b/network/peer/ip_signer_test.go
@@ -51,5 +51,5 @@ func TestIPSigner(t *testing.T) {
 	require.NoError(err)
 	require.Equal(dynIP.IPPort(), signedIP3.IPPort)
 	require.Equal(uint64(11), signedIP3.Timestamp)
-	require.NotEqualValues(signedIP2.Signature, signedIP3.Signature)
+	require.NotEqual(signedIP2.Signature, signedIP3.Signature)
 }
diff --git a/utils/sampler/uniform_test.go b/utils/sampler/uniform_test.go
@@ -175,7 +175,7 @@ func TestSeeding(t *testing.T) {
 	s1.Seed(0)
 	v, err := s2.Next()
 	require.NoError(err)
-	require.NotEqualValues(s1Val, v)
+	require.NotEqual(s1Val, v)
 
 	s1.ClearSeed()