Add StructTag linter (ava-labs#2230)

vasiigor575 · Nov 14, 2022 · 6cf3f67 · 6cf3f67
1 parent 2720392
commit 6cf3f67
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -53,6 +53,9 @@ linters:
 linters-settings:
   revive:
     rules:
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#struct-tag
+      - name: struct-tag
+        disabled: false
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#unexported-naming
       - name: unexported-naming
         disabled: false

diff --git a/codec/test_codec.go b/codec/test_codec.go
@@ -613,7 +613,7 @@ func TestSerializeUnexportedField(codec GeneralCodec, t testing.TB) {
 
 	type s struct {
 		ExportedField   string `serialize:"true"`
-		unexportedField string `serialize:"true"`
+		unexportedField string `serialize:"true"` //nolint:revive
 	}
 
 	myS := s{

diff --git a/vms/secp256k1fx/output_owners.go b/vms/secp256k1fx/output_owners.go
@@ -28,10 +28,11 @@ type OutputOwners struct {
 	Locktime  uint64        `serialize:"true" json:"locktime"`
 	Threshold uint32        `serialize:"true" json:"threshold"`
 	Addrs     []ids.ShortID `serialize:"true" json:"addresses"`
+
 	// ctx is used in MarshalJSON to convert Addrs into human readable
 	// format with ChainID and NetworkID. Unexported because we don't use
 	// it outside this object.
-	ctx *snow.Context `serialize:"false"`
+	ctx *snow.Context
 }
 
 // InitCtx assigns the OutputOwners.ctx object to given [ctx] object