snow/engine/snowman: instantiate voter after issuer (ava-labs#1610)

vasiigor575 · Jun 13, 2023 · a3436f1 · a3436f1
1 parent 31db450
commit a3436f1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/snow/engine/snowman/transitive.go b/snow/engine/snowman/transitive.go
@@ -257,6 +257,11 @@ func (t *Transitive) Chits(ctx context.Context, nodeID ids.NodeID, requestID uin
 		zap.Stringer("nodeID", nodeID),
 		zap.Uint32("requestID", requestID))
 
+	added, err := t.issueFromByID(ctx, nodeID, blkID)
+	if err != nil {
+		return err
+	}
+
 	// Will record chits once [blkID] has been issued into consensus
 	v := &voter{
 		t:         t,
@@ -265,10 +270,6 @@ func (t *Transitive) Chits(ctx context.Context, nodeID ids.NodeID, requestID uin
 		response:  blkID,
 	}
 
-	added, err := t.issueFromByID(ctx, nodeID, blkID)
-	if err != nil {
-		return err
-	}
 	// Wait until [blkID] has been issued to consensus before applying this chit.
 	if !added {
 		v.deps.Add(blkID)