Standardize set.Bits method naming with set.Bits64 (ava-labs#2667)

utils/set/bits.go

@@ -67,13 +67,16 @@ func (b Bits) Contains(i int) bool {
 	return b.bits.Bit(i) == 1
 }
 
-// Len returns the bit length of this bitset
-func (b Bits) Len() int {
+// BitLen returns the bit length of this bitset
+func (b Bits) BitLen() int {
 	return b.bits.BitLen()
 }
 
-// HammingWeight returns the amount of 1's in the bitset
-func (b Bits) HammingWeight() int {
+// Len returns the amount of 1's in the bitset
+//
+// This is typically referred to as the "Hamming Weight"
+// of a set of bits.
+func (b Bits) Len() int {
 	result := 0
 	for _, word := range b.bits.Bits() {
 		result += bits.OnesCount(uint(word))

utils/set/bits_test.go

@@ -36,7 +36,7 @@ func Test_Bits_New(t *testing.T) {
 				require.True(b.Contains(bit))
 			}
 
-			require.Equal(test.length, b.Len())
+			require.Equal(test.length, b.BitLen())
 		})
 	}
 }
@@ -124,7 +124,7 @@ func Test_Bits_AddRemove(t *testing.T) {
 				require.True(b.Contains(element))
 			}
 
-			require.Equal(test.expectedLen, b.Len())
+			require.Equal(test.expectedLen, b.BitLen())
 		})
 	}
 }
@@ -197,7 +197,7 @@ func Test_Bits_Union(t *testing.T) {
 				require.True(b.Contains(element))
 			}
 
-			require.Equal(test.expectedLen, b.Len())
+			require.Equal(test.expectedLen, b.BitLen())
 		})
 	}
 }
@@ -383,7 +383,7 @@ func Test_Bits_Clear(t *testing.T) {
 
 			b.Clear()
 
-			require.Zero(b.Len())
+			require.Zero(b.BitLen())
 		})
 	}
 }
@@ -419,7 +419,7 @@ func Test_Bits_String(t *testing.T) {
 	}
 }
 
-func Test_Bits_HammingWeight(t *testing.T) {
+func Test_Bits_Len(t *testing.T) {
 	tests := []struct {
 		name     string
 		bitset   []int
@@ -465,7 +465,7 @@ func Test_Bits_HammingWeight(t *testing.T) {
 				b.Add(bit)
 			}
 
-			require.Equal(test.expected, b.HammingWeight())
+			require.Equal(test.expected, b.Len())
 		})
 	}
 }
@@ -499,7 +499,7 @@ func Test_Bits_Bytes(t *testing.T) {
 			bytes := b.Bytes()
 			fromBytes := BitsFromBytes(bytes)
 
-			require.Equal(len(tt.elts), fromBytes.HammingWeight())
+			require.Equal(len(tt.elts), fromBytes.Len())
 			for _, elt := range tt.elts {
 				require.True(fromBytes.Contains(elt))
 			}

vms/platformvm/warp/signature.go

@@ -61,7 +61,7 @@ func (s *BitSetSignature) NumSigners() (int, error) {
 	if len(signerIndices.Bytes()) != len(s.Signers) {
 		return 0, ErrInvalidBitSet
 	}
-	return signerIndices.HammingWeight(), nil
+	return signerIndices.Len(), nil
 }
 
 func (s *BitSetSignature) Verify(

vms/platformvm/warp/validator.go

@@ -95,11 +95,11 @@ func FilterValidators(
 	vdrs []*Validator,
 ) ([]*Validator, error) {
 	// Verify that all alleged signers exist
-	if indices.Len() > len(vdrs) {
+	if indices.BitLen() > len(vdrs) {
 		return nil, fmt.Errorf(
 			"%w: %d >= %d",
 			ErrUnknownValidator,
-			indices.Len()-1, // -1 to convert from length to index
+			indices.BitLen()-1, // -1 to convert from length to index
 			len(vdrs),
 		)
 	}