Skip to content

Commit

Permalink
[PATCH] snsc: switch from force_sig to kill_proc
Browse files Browse the repository at this point in the history
Currently the snsc driver uses force_sig to send init a SIGPWR when the
system overheats.  This patch switches it to kill_proc instead which has
the following advantages:

 (1) gets rid of one of the last remaining tasklist_lock users
     in modular code
 (2) simplifies the snsc code significantly

The downside is that an init implementation could in theory block SIGPWR
and it would not get delivered.  The sysvinit code used by all major
distributions doesn't do this and blocking this signal in init would be a
rather stupid thing to do.

Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Christoph Hellwig authored and Linus Torvalds committed Jul 10, 2006
1 parent babcfad commit 5c318be
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions drivers/char/snsc_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,20 +220,7 @@ scdrv_dispatch_event(char *event, int len)
" Sending SIGPWR to init...\n");

/* give a SIGPWR signal to init proc */

/* first find init's task */
read_lock(&tasklist_lock);
for_each_process(p) {
if (p->pid == 1)
break;
}
if (p) {
force_sig(SIGPWR, p);
} else {
printk(KERN_ERR "Failed to signal init!\n");
snsc_shutting_down = 0; /* so can try again (?) */
}
read_unlock(&tasklist_lock);
kill_proc(1, SIGPWR, 0);
} else {
/* print to system log */
printk("%s|$(0x%x)%s\n", severity, esp_code, desc);
Expand Down

0 comments on commit 5c318be

Please sign in to comment.