Skip to content

Commit

Permalink
scsi: fix fall out of sg-chaining patch in qlogicpti
Browse files Browse the repository at this point in the history
Boaz writes:

"I've reviewed all patches since Matthew's, and I find one small
problem.

In the load_cmd() there is a compound loop where the first 4 sg's are
set then the rest are set into a memory structure in group of 7 sg's.

Well the second 7-group and on is a bug because sg pointer does not advance.
This is a fall out from Jens's patch."

The reporter, Meelis Roos <[email protected]>, verified that this patch
does indeed fix his problem with qlogicpti.

Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Boaz Harrosh authored and Jens Axboe committed Sep 29, 2008
1 parent 6ef190c commit 7e6cfb5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/scsi/qlogicpti.c
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,7 @@ static inline int load_cmd(struct scsi_cmnd *Cmnd, struct Command_Entry *cmd,
ds[i].d_count = sg_dma_len(s);
}
sg_count -= n;
sg = s;
}
} else {
cmd->dataseg[0].d_base = 0;
Expand Down

0 comments on commit 7e6cfb5

Please sign in to comment.