Skip to content

Commit

Permalink
dmaengine: pch_dma: use tasklet_kill in teardown
Browse files Browse the repository at this point in the history
As discussed in [1] the tasklet_disable is not a proper function for teardown.
We need to ensure irq is disabled, followed by ensuring that don't schedule any
more tasklets and then its safe to use tasklet_kill().

Here in pch dma driver we need to use free_irq() before tasklet_kill(). So move
up the free_irq() which will ensure that the irq is disabled and also wait till
all scheduled interrupts are executed by invoking synchronize_irq().

[1]: http://lwn.net/Articles/588457/

Reported-by: Thomas Gleixner <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
Vinod Koul committed Mar 17, 2014
1 parent ccc7aad commit 9068b03
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/dma/pch_dma.c
Original file line number Diff line number Diff line change
@@ -964,16 +964,16 @@ static void pch_dma_remove(struct pci_dev *pdev)
if (pd) {
dma_async_device_unregister(&pd->dma);

free_irq(pdev->irq, pd);

list_for_each_entry_safe(chan, _c, &pd->dma.channels,
device_node) {
pd_chan = to_pd_chan(chan);

tasklet_disable(&pd_chan->tasklet);
tasklet_kill(&pd_chan->tasklet);
}

pci_pool_destroy(pd->pool);
free_irq(pdev->irq, pd);
pci_iounmap(pdev, pd->membase);
pci_release_regions(pdev);
pci_disable_device(pdev);

0 comments on commit 9068b03

Please sign in to comment.