HSI: hsi: Fix error path cleanup on client registration

HSI client structure should be freed on error path after calling device_registration by dropping a reference to it. Signed-off-by: Carlos Chinea <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Acked-by: Linus Walleij <[email protected]>
vbatts · Apr 23, 2012 · 90e41f9 · 90e41f9
1 parent 5a218ce
commit 90e41f9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c
@@ -100,7 +100,7 @@ static void hsi_new_client(struct hsi_port *port, struct hsi_board_info *info)
 		cl->device.archdata = *info->archdata;
 	if (device_register(&cl->device) < 0) {
 		pr_err("hsi: failed to register client: %s\n", info->name);
-		kfree(cl);
+		put_device(&cl->device);
 	}
 }