Skip to content

Commit

Permalink
Ocfs2/refcounttree: Fix a bug for refcounttree to writeback clusters …
Browse files Browse the repository at this point in the history
…in a right number.

Current refcounttree codes actually didn't writeback the new pages out in
write-back mode, due to a bug of always passing a ZERO number of clusters
to 'ocfs2_cow_sync_writeback', the patch tries to pass a proper one in.

Signed-off-by: Tristan Ye <[email protected]>
Cc: [email protected]
Signed-off-by: Joel Becker <[email protected]>
  • Loading branch information
Tristan Ye authored and jlbec committed Feb 20, 2011
1 parent 705773a commit acf3bb0
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions fs/ocfs2/refcounttree.c
Original file line number Diff line number Diff line change
Expand Up @@ -3228,7 +3228,7 @@ static int ocfs2_make_clusters_writable(struct super_block *sb,
u32 num_clusters, unsigned int e_flags)
{
int ret, delete, index, credits = 0;
u32 new_bit, new_len;
u32 new_bit, new_len, orig_num_clusters;
unsigned int set_len;
struct ocfs2_super *osb = OCFS2_SB(sb);
handle_t *handle;
Expand Down Expand Up @@ -3261,6 +3261,8 @@ static int ocfs2_make_clusters_writable(struct super_block *sb,
goto out;
}

orig_num_clusters = num_clusters;

while (num_clusters) {
ret = ocfs2_get_refcount_rec(ref_ci, context->ref_root_bh,
p_cluster, num_clusters,
Expand Down Expand Up @@ -3348,7 +3350,8 @@ static int ocfs2_make_clusters_writable(struct super_block *sb,
* in write-back mode.
*/
if (context->get_clusters == ocfs2_di_get_clusters) {
ret = ocfs2_cow_sync_writeback(sb, context, cpos, num_clusters);
ret = ocfs2_cow_sync_writeback(sb, context, cpos,
orig_num_clusters);
if (ret)
mlog_errno(ret);
}
Expand Down

0 comments on commit acf3bb0

Please sign in to comment.