dlm: config: using strlcpy instead of strncpy

for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Zhao Hongjiang <[email protected]> Signed-off-by: David Teigland <[email protected]>
vbatts · Jun 25, 2013 · ad917e7 · ad917e7
1 parent 06452eb
commit ad917e7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
@@ -138,8 +138,9 @@ static ssize_t cluster_cluster_name_read(struct dlm_cluster *cl, char *buf)
 static ssize_t cluster_cluster_name_write(struct dlm_cluster *cl,
 					  const char *buf, size_t len)
 {
-	strncpy(dlm_config.ci_cluster_name, buf, DLM_LOCKSPACE_LEN);
-	strncpy(cl->cl_cluster_name, buf, DLM_LOCKSPACE_LEN);
+	strlcpy(dlm_config.ci_cluster_name, buf,
+				sizeof(dlm_config.ci_cluster_name));
+	strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name));
 	return len;
 }