PivorakWebApp
Join our slack chat!
We have special #pivorak-web-app channel for contributors.
master- stable code, production deployment.development- dev branch, staging deployment. Please checkout your new branch from it.
- Detect which issue you want to resolve. Write comment about this and how you supposed to do this.
- Fork project (if you don't have permissions to push).
- Checkout new branch with name
"#{issue_id}-#{add or fix or improve}-#{job-done-description}"(77-add-feature), write tests, write code, compose nice commit message"##{issue-id} commit message text"(#77 Add feature :tada:-> you may use emoji) and push your branch to origin. - Create merge request into development branch, add reviewers.
- Thank you!
Model should containe only data-logic.
- Processing -> to service/interactor.
- Complex queries -> to finders
- Predicates -> to policy.
View should be clean as much as possible. Please, use helpers to avoid call methods with some params at template.
Skinny controller. Only REST. Only 7 allowed actions (index, show, new, create, edit, update, destroy). If you need additional action - extract to new sub-controller
Single responsibility resource action that represents business logic.
Only one public method allowed .call. Everething else - to private
QueryObject.
Domain predicates store. Knows answers for all questions.
- Go to issue tracker
- Add descriptive title
- Add steps to reproduce with screenshots
- Add label bug
- What happens and what you expected to happen
- Browser if it is UI related issue