pencilblue#970 more unit tests

veimis · Nov 29, 2016 · e2954f1 · e2954f1
1 parent 86593d8
commit e2954f1
Show file tree

Hide file tree

Showing 2 changed files with 64 additions and 5 deletions.
diff --git a/include/http/middleware/index.js b/include/http/middleware/index.js
@@ -219,14 +219,14 @@ module.exports = function(pb) {
          */
         static deriveRouteTheme (req, res, next) {
 
-            //routeTheme describes the site/theme/method combo
+            // routeTheme describes the site/theme/method combo
             var rt = req.handler.routeTheme = req.routeTheme = req.handler.getRouteTheme(req.activeTheme, req.route);
             if (rt.theme === null || rt.method === null || rt.site === null) {
                 return next(ErrorUtils.notFound());
             }
 
-            //while themeRoute describes the specific route definition based on the theme
-            //TODO [1.0] super confusing and should be changed
+            // themeRoute describes the specific route definition based on the theme
+            // TODO [1.0] super confusing and should be changed
             req.handler.themeRoute = req.themeRoute = req.route.themes[rt.site][rt.theme][rt.method];
             if (pb.log.isSilly()) {
                 pb.log.silly("RequestHandler: Settling on theme [%s] and method [%s] for URL=[%s:%s]", rt.theme, rt.method, req.method, req.handler.url.href);

diff --git a/test/include/http/middleware/index.spec.js b/test/include/http/middleware/index.spec.js
@@ -263,8 +263,67 @@ describe('Middleware', function() {
 
     describe('deriveRouteTheme', function() {
 
-        it('', function(done) {
-            done();
+        beforeEach(function() {
+            req.activeTheme = 'some-active-theme';
+            req.route = {
+                themes: {
+                    global: {
+                        pencilblue: {
+                            'get': {
+                                hello: 'world'
+                            }
+                        }
+                    }
+                }
+            };
+        });
+
+        [
+            {
+                theme: null,
+                method: 'get',
+                site: 'global'
+            },
+            {
+                theme: 'pencilblue',
+                method: null,
+                site: 'global'
+            },
+            {
+            theme: 'pencilblue',
+            method: 'get',
+            site: null
+            }
+        ].forEach(function(routeTheme) {
+            it('should call back with a not found error when the route theme returns with: ' + JSON.stringify(routeTheme), function(done) {
+                sandbox.stub(req.handler, 'getRouteTheme')
+                    .withArgs(req.activeTheme, req.route)
+                    .returns(routeTheme);
+                this.pb.Middleware.deriveRouteTheme(req, res, function(err) {
+                    err.code.should.eql(HttpStatusCodes.NOT_FOUND);
+                    should(req.themeRoute).eql(undefined);
+                    should(req.handler.themeRoute).eql(undefined);
+
+                    done();
+                });
+            });
+        });
+
+        it('should derive the themed route from the route definition', function(done) {
+            var routeTheme = {
+                theme: 'pencilblue',
+                method: 'get',
+                site: 'global'
+            };
+            sandbox.stub(req.handler, 'getRouteTheme')
+                .withArgs(req.activeTheme, req.route)
+                .returns(routeTheme);
+            this.pb.Middleware.deriveRouteTheme(req, res, function(err) {
+                should(err).eql(undefined);
+                req.themeRoute.should.eql(req.route.themes.global.pencilblue.get);
+                req.handler.themeRoute.should.eql(req.route.themes.global.pencilblue.get);
+                done();
+            });
         });
     });