Skip to content

Commit

Permalink
Replaced APPROX_ADAGRAD and APPROX_ROWWISE_ADAGRAD with EXACT_ADAGRAD…
Browse files Browse the repository at this point in the history
… and EXACT_ROWWISE_ADAGRAD

Summary:
Updated `APPROX_ADAGRAD` and `APPROX_ROWWISE_ADAGRAD` to `EXACT_ADAGRAD` and `EXACT_ROWWISE_ADAGRAD`.

Removed `to_exact` function and usage.

Removed `APPROX_` usage in enums.

Fixed test with `EXACT_SGD` instead of `SGD`

Reviewed By: jianyuh

Differential Revision: D26380060

fbshipit-source-id: 1ea806414944df296a53ae604b03b39814ca5415
  • Loading branch information
Andrew Wang authored and facebook-github-bot committed Feb 16, 2021
1 parent b51f3e6 commit aa1b4e6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fbgemm_gpu/split_embedding_configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ class EmbOptimType(enum.Enum):
)
LAMB = "lamb"
ADAM = "adam"
# approx refers to that gradients to the same row are applied in sequence
# instead of first coalescing gradients then apply together
APPROX_ADAGRAD = "adagrad"
APPROX_ROWWISE_ADAGRAD = "approx_row_wise_adagrad"
# exact/dedup: gradients to the same row are applied with coalesce then apply
# together, instead of applied in sequence (approx).
EXACT_ADAGRAD = "exact_adagrad"
Expand Down

0 comments on commit aa1b4e6

Please sign in to comment.