Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't drop queued actions when navigating #75362

Draft
wants to merge 3 commits into
base: canary
Choose a base branch
from
+73 −2
Draft

fix: don't drop queued actions when navigating #75362

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeac8c5
fix: don't drop queued actions when navigating
lubieowoce Jan 27, 2025
c41754f
comment
lubieowoce Jan 27, 2025
be21ed1
test: wip
lubieowoce Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@lubieowoce
lubieowoce committed Jan 27, 2025
commit c41754f9eb845acfc45495aaa07f0bb12ee00507
2 changes: 2 additions & 0 deletions packages/next/src/shared/lib/router/action-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ function dispatchAction(
// Mark the pending action as discarded (so the state is never applied) and start the navigation action immediately.
actionQueue.pending.discarded = true

// The rest of the current queue should still execute after this navigation.
// (Note that it can't contain any earlier navigations, because we always put those into `actionQueue.pending` by calling `runAction`)
newAction.next = actionQueue.pending.next

// if the pending action was a server action, mark the queue as needing a refresh once events are processed
Expand Down