feat(tui): bind to toggle task selection pinning #9609
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
13 tasks
anthonyshew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While task selection pinning is convenient when tasks are changing order and status, it can sometimes get in the way.
When you haven't selected a task yet (e.g. pressed one of ↑/↓/j/k), you are in an unpinned state. You'll always be looking at the first task in the list, even as they shuffle around in order. When you do press one of those keys, you end up in a pinned state such that the task you selected continues to be selected.
This feels good until you select a task, and then want to "exit" that pinned state and let tasks flow around beneath your cursor again. In this PR, we solve this problem, adding a keybind for
pthat toggles the pinned/unpinned state of your selection.Testing Instructions
Pick out your favorite Turborepo, run tasks with the TUI, and try out this new feature.