-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tui): change binds for log scrolling and add UI hints #9610
Open
anthonyshew
wants to merge
4
commits into
main
Choose a base branch
from
shew-2d6c7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
13 tasks
anthonyshew
changed the title
feat(tui): change binds for log scrolling
feat(tui): change binds for log scrolling and add UI hints
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the binds for scrolling logs from
CTRL+P
andCTRL+N
tou
andd
. I'm learning into simple here, both by making the bind a simple one-tap instead of a chord and matching up with the mnemonic device of "up and down".Minor hesitation
CTRL+n
andCTRL+p
are familiar to power users of a few terminal tools, but I personally don't see this as a great justification for our tool, which gets used by a much broader audience. I'm erring on the side of simplicity, but happy to hear dissent/pushback/other thoughts.Additionally, I've updated our UI hints slightly:
Testing Instructions
Pick out your favorite Turborepo and try it out!