Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): change binds for log scrolling and add UI hints #9610

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Dec 12, 2024

Description

This PR changes the binds for scrolling logs from CTRL+P and CTRL+N to u and d. I'm learning into simple here, both by making the bind a simple one-tap instead of a chord and matching up with the mnemonic device of "up and down".

Minor hesitation

CTRL+n and CTRL+p are familiar to power users of a few terminal tools, but I personally don't see this as a great justification for our tool, which gets used by a much broader audience. I'm erring on the side of simplicity, but happy to hear dissent/pushback/other thoughts.

Additionally, I've updated our UI hints slightly:

  • Added the hints for these binds to the logs pane
  • Separating binds using spaces instead of commas

Testing Instructions

Pick out your favorite Turborepo and try it out!

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:27am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant