Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions to install docker engine and docker compose #10

Merged
merged 9 commits into from
Aug 1, 2016
Merged

Instructions to install docker engine and docker compose #10

merged 9 commits into from
Aug 1, 2016

Conversation

bitoiu
Copy link
Contributor

@bitoiu bitoiu commented Jul 30, 2016

Hey @reiz,

I was following the guide and I noticed it that although the install guide depends onjq, docker and docker-compose it only has the details on how to install jq.

This PR:

  • Creates a doc hierarchy on the environment dependencies
  • Adds the instructions (or links) to the official docker and docker-compose guides
  • Adds a bit of testing to validate the docker dependencies (although this is part of the guides themselves)

Let me know if you want me to change this in anyway.

:octocat:❤️

@bitoiu
Copy link
Contributor Author

bitoiu commented Jul 30, 2016

After creating the pull request I've added a few other things:

  • In hindsight the versioneye-base.yml is very easy to find in the root folder, but I would expect a link to it. Instead of adding the link I've just setup a curl to do it.
  • In the following step I noticed other 2 files that were needed, the start and stop scripts. I've added those to the curl and also added the chmod +x

I'm not sure if you want these things in @reiz, so let me know if this is more verbose than you think it needs to be.

:octocat:❤️

@bitoiu
Copy link
Contributor Author

bitoiu commented Jul 30, 2016

@reiz I did a 180 on the whole curl to download the files. I noticed you need pretty much everything on the root of the repository. I guess your original goal was for folks to clone it anyway, so I added that in the very beginning and deleted all the individual curls.

Sorry for this back and fw, but somethings only became apparent as I went through the docs.

@reiz reiz merged commit 253f6b2 into versioneye:master Aug 1, 2016
@reiz
Copy link
Member

reiz commented Aug 1, 2016

Hi @bitoiu. Many Thanks for all the improvements :-) I think the people who want to use this will clone the whole repo, that's why I don't think we need the curl commands to download files from this repo.

@bitoiu
Copy link
Contributor Author

bitoiu commented Aug 1, 2016

I think the people who want to use this will clone the whole repo, that's why I don't think we need the curl commands to download files from this repo.

That's why I removed everything in the end and used the git clone in the first chapter @reiz 😄

My first approach wasn't a clone, because some instances you launch these days don't have Git and that's yet another dependency 😢

Thanks for merging.

@bitoiu bitoiu deleted the environment-docker-compose branch August 1, 2016 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants