-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions to install docker engine and docker compose #10
Conversation
…ntrib into environment-docker-compose
After creating the pull request I've added a few other things:
I'm not sure if you want these things in @reiz, so let me know if this is more verbose than you think it needs to be. ❤️ |
@reiz I did a 180 on the whole Sorry for this back and fw, but somethings only became apparent as I went through the docs. |
Hi @bitoiu. Many Thanks for all the improvements :-) I think the people who want to use this will clone the whole repo, that's why I don't think we need the curl commands to download files from this repo. |
That's why I removed everything in the end and used the git clone in the first chapter @reiz 😄 My first approach wasn't a clone, because some instances you launch these days don't have Git and that's yet another dependency 😢 Thanks for merging. |
Hey @reiz,
I was following the guide and I noticed it that although the install guide depends on
jq
,docker
anddocker-compose
it only has the details on how to installjq
.This PR:
docker
anddocker-compose
guidesLet me know if you want me to change this in anyway.
❤️