Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParameterType.LONG #1669

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add ParameterType.LONG #1669

wants to merge 3 commits into from

Conversation

arniu
Copy link
Contributor

@arniu arniu commented Jul 25, 2020

Motivation:

Add missing LONG

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@arniu arniu changed the title Add Long Add ParameterType.LONG Jul 25, 2020
@arniu arniu marked this pull request as ready for review July 25, 2020 07:47
@slinkydeveloper
Copy link
Member

Hello, thanks for contributing! Can i ask what is the reason of this change? Also, yuo need to sign the eclipse eca and signoff your commits

@arniu
Copy link
Contributor Author

arniu commented Jul 27, 2020

Long was supported in RequestParameter, while absent in ParameterType.

@Nullable Long getLong();
/**
* Returns true if value of RequestParameter is a Long instance
*
* @return
*/
boolean isLong();

@slinkydeveloper
Copy link
Member

sounds good to me. Can you sign off the commits and sign the eclipse eca?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants