Skip to content

Commit

Permalink
Update wording for the guide to creating a pull request.
Browse files Browse the repository at this point in the history
The button that starts the pull request process is displayed on both the
original and forked repositories, so this updates that paragraph.
Also, if the link is not displayed, you have to go to the forked repository
to initiate a one by clicking 'pull requests' in the right-side menu
instead of doing it from the original.  This commit updates the list items
with those steps too.

And lastly, I only knew how to try and contribute these changes because I
completed the challenges earlier today.  THANK YOU for this guide!
  • Loading branch information
jasonevrtt committed Aug 30, 2015
1 parent 4b000eb commit 3dd0cfe
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
11 changes: 7 additions & 4 deletions guide/challenges/requesting_you_pull_please.html
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,17 @@ <h2>Step: Create a pull request</h2>
<p>Visit the original repository you forked on GitHub, in this case
<a href="https://github.com/jlord/patchwork">http://github.com/jlord/patchwork</a>.</p>

<p>Often GitHub will detect if you've pushed a branch to a fork and
display it at the top of the original's website. If you see that with your 'add-username' branch,
you can click Create Pull Request from there. If not:</p>
<p>Often GitHub will detect when you've pushed a branch to a fork, and display
a 'Compare & pull request' button at the top of both the original and forked
repositories. If you see this for your 'add-username' branch, you can click it
to continue. If not:</p>

<ul>
<li>Click 'Pull request' on the right-side menu, then 'New pull request'.</li>
<li>Go to your forked repository.</li>
<li>Click 'Pull requests' on the right-side menu, then 'New pull request' at the top.</li>
<li>Select the branch with the changes you want to submit. <strong>It should be
the one with 'add-yourusername'</strong>.</li>
<li>Click 'Create pull request' at the top.</li>
</ul>

<p>You'll now see a page with the details of the pull request you're
Expand Down
11 changes: 7 additions & 4 deletions guide/raw-content/10_requesting_you_pull_please.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@ <h2>Step: Create a pull request</h2>
<p>Visit the original repository you forked on GitHub, in this case
<a href="https://github.com/jlord/patchwork">http://github.com/jlord/patchwork</a>.</p>

<p>Often GitHub will detect if you've pushed a branch to a fork and
display it at the top of the original's website. If you see that with your 'add-username' branch,
you can click Create Pull Request from there. If not:</p>
<p>Often GitHub will detect when you've pushed a branch to a fork, and display
a 'Compare & pull request' button at the top of both the original and forked
repositories. If you see this for your 'add-username' branch, you can click it
to continue. If not:</p>

<ul>
<li>Click 'Pull request' on the right-side menu, then 'New pull request'.</li>
<li>Go to your forked repository.</li>
<li>Click 'Pull requests' on the right-side menu, then 'New pull request' at the top.</li>
<li>Select the branch with the changes you want to submit. <strong>It should be
the one with 'add-yourusername'</strong>.</li>
<li>Click 'Create pull request' at the top.</li>
</ul>

<p>You'll now see a page with the details of the pull request you're
Expand Down

0 comments on commit 3dd0cfe

Please sign in to comment.