Skip to content

Commit

Permalink
provision: Fix some shell hygiene.
Browse files Browse the repository at this point in the history
An array expansion should nearly always be double-quoted, like `"$@"`.
See http://mywiki.wooledge.org/Quotes for some discussion.
  • Loading branch information
gnprice authored and timabbott committed Aug 9, 2017
1 parent 2b45c17 commit a32a3cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/provision
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ echo "PROVISIONING STARTING." >> $LOG_PATH
# PYTHONUNBUFFERED is important to ensure that tracebacks don't get
# lost far above where they should be in the output.
export PYTHONUNBUFFERED=1
"$PYTHON" "$PROVISION_PATH" $@ 2>&1 | tee -a "$LOG_PATH"
"$PYTHON" "$PROVISION_PATH" "$@" 2>&1 | tee -a "$LOG_PATH"
failed=${PIPESTATUS[0]}

if [ $failed = 1 ]; then
Expand Down

0 comments on commit a32a3cf

Please sign in to comment.