Refactor code-style

vfile · Jun 11, 2022 · d5b9154 · d5b9154
1 parent db4d87b
commit d5b9154
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 21 deletions.
diff --git a/index.js b/index.js
@@ -3,12 +3,12 @@
  * @typedef {import('vfile-message').VFileMessage} VFileMessage
  */
 
-var severities = {true: 2, false: 1, null: 0, undefined: 0}
+const severities = {true: 2, false: 1, null: 0, undefined: 0}
 
 /**
- * @template {VFile} F
- * @param {F} file
- * @returns {F}
+ * @template {VFile} File
+ * @param {File} file
+ * @returns {File}
  */
 export function sort(file) {
   file.messages.sort(comparator)
@@ -35,19 +35,19 @@ function comparator(a, b) {
 /**
  * @param {VFileMessage} a
  * @param {VFileMessage} b
- * @param {string} property
+ * @param {string} field
  * @returns {number}
  */
-function check(a, b, property) {
-  return (a[property] || 0) - (b[property] || 0)
+function check(a, b, field) {
+  return (a[field] || 0) - (b[field] || 0)
 }
 
 /**
  * @param {VFileMessage} a
  * @param {VFileMessage} b
- * @param {string} property
+ * @param {string} field
  * @returns {number}
  */
-function compare(a, b, property) {
-  return String(a[property] || '').localeCompare(b[property] || '')
+function compare(a, b, field) {
+  return String(a[field] || '').localeCompare(b[field] || '')
 }
diff --git a/package.json b/package.json
@@ -65,11 +65,7 @@
     "trailingComma": "none"
   },
   "xo": {
-    "prettier": true,
-    "rules": {
-      "no-var": "off",
-      "prefer-arrow-callback": "off"
-    }
+    "prettier": true
   },
   "remarkConfig": {
     "plugins": [

diff --git a/test.js b/test.js
@@ -3,21 +3,21 @@ import {VFile} from 'vfile'
 import {sort} from './index.js'
 
 test('sort()', function (t) {
-  var file = new VFile()
+  let file = new VFile()
 
-  // @ts-ignore runtime.
+  // @ts-expect-error runtime.
   file.message('Hotel', {column: 0})
   file.message('Foxtrot')
-  // @ts-ignore runtime.
+  // @ts-expect-error runtime.
   file.message('Alpha', {line: 3})
   file.message('Bravo', {line: 3, column: 1})
   file.message('Charlie', {line: 3, column: 2})
   file.message('Delta', {line: 0, column: 1})
-  // @ts-ignore runtime.
+  // @ts-expect-error runtime.
   file.message('Echo', {column: 1})
-  // @ts-ignore runtime.
+  // @ts-expect-error runtime.
   file.message('Golf', {line: 0})
-  // @ts-ignore runtime.
+  // @ts-expect-error runtime.
   file.message('Golf', {line: 0})
 
   t.deepEqual(sort(file).messages.map(String), [