Skip to content

Commit

Permalink
debuginfo: Make names of types in debuginfo reliable and omit source …
Browse files Browse the repository at this point in the history
…locations from debug info type descriptions.

So far, type names generated for debuginfo where a bit sketchy. It was not clearly defined when a name should be fully qualified and when not, if region parameters should be shown or not, and other things like that.
This commit makes the debuginfo module responsible for creating type names instead of using ppaux::ty_to_str() and brings type names, as they show up in the DWARF information, in line with GCC and Clang:

* The name of the type being described is unqualified. It's path is defined by its position in the namespace hierarchy.
* Type arguments are always fully qualified, no matter if they would actually be in scope at the type definition location.

Care is also taken to reliably make type names consistent across crate boundaries. That is, the code now tries make the type name the same, regardless if the type is in the local crate or reconstructed from metadata. Otherwise LLVM will complain about violating the one-definition-rule when using link-time-optimization.

This commit also removes all source location information from type descriptions because these cannot be reconstructed for types instantiated from metadata. Again, with LTO enabled, this can lead to two versions of the debuginfo type description, one with and one without source location information, which then triggers the LLVM ODR assertion.
Fortunately, source location information about types is rarely used, so this has little impact. Once source location information is preserved in metadata (rust-lang#1972) it can also be reenabled for type descriptions.
  • Loading branch information
michaelwoerister committed Jul 2, 2014
1 parent 89259b3 commit 40e0541
Show file tree
Hide file tree
Showing 2 changed files with 744 additions and 184 deletions.
Loading

0 comments on commit 40e0541

Please sign in to comment.