Skip to content

Commit

Permalink
irq_work: Make irq_work_queue() NMI-safe again
Browse files Browse the repository at this point in the history
Someone carelessly put NMI unsafe code in irq_work_queue(), breaking
just about every single user. Also, someone has a terrible comment
style.

Fixes: e2b5bcf ("irq_work: record irq_work_queue() call stack")
Reported-by: Alexander Shishkin <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
  • Loading branch information
Peter Zijlstra committed Jun 10, 2021
1 parent 848ff37 commit 156172a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions kernel/irq_work.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ bool irq_work_queue(struct irq_work *work)
if (!irq_work_claim(work))
return false;

/*record irq_work call stack in order to print it in KASAN reports*/
kasan_record_aux_stack(work);

/* Queue the entry and raise the IPI if needed. */
preempt_disable();
__irq_work_queue_local(work);
Expand Down

0 comments on commit 156172a

Please sign in to comment.