Skip to content

Commit

Permalink
selftests/vm: make MADV_POPULATE_(READ|WRITE) use in-tree headers
Browse files Browse the repository at this point in the history
The madv_populate selftest currently builds with a warning when the
local installed headers (via the distribution) don't include
MADV_POPULATE_READ and MADV_POPULATE_WRITE.  The warning is correct,
because the test cannot locate the necessary header.

The reason is that the in-tree installed headers (usr/include) have a
"linux" instead of a "sys" subdirectory.

Including "linux/mman.h" instead of "sys/mman.h" doesn't work (e.g.,
mmap() and madvise() are not defined that way).  The only thing that
seems to work is including "linux/mman.h" in addition to "sys/mman.h".

We can get rid of our availability check and simplify.

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: David Hildenbrand <[email protected]>
Reported-by: Shuah Khan <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
davidhildenbrand authored and torvalds committed Nov 6, 2021
1 parent a997058 commit 39b2e5c
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions tools/testing/selftests/vm/madv_populate.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
#include <linux/mman.h>
#include <sys/mman.h>

#include "../kselftest.h"

#if defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE)

/*
* For now, we're using 2 MiB of private anonymous memory for all tests.
*/
Expand Down Expand Up @@ -328,15 +327,3 @@ int main(int argc, char **argv)
err, ksft_test_num());
return ksft_exit_pass();
}

#else /* defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE) */

#warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition"

int main(int argc, char **argv)
{
ksft_print_header();
ksft_exit_skip("MADV_POPULATE_READ or MADV_POPULATE_WRITE not defined\n");
}

#endif /* defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE) */

0 comments on commit 39b2e5c

Please sign in to comment.