Skip to content

Commit

Permalink
phy: qualcomm: fix setting of tx_deamp_3_5db when device property rea…
Browse files Browse the repository at this point in the history
…d fails

Currently when reading of the device property for "qcom,tx-deamp_3_5db"
fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
looks like a copy-n-paste error and in fact should be assigning the
default instead to phy_dwc3->tx_deamp_3_5db

Addresses-Coverity: ("Copy-paste error")
Fixes: ef19b11 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
Signed-off-by: Colin Ian King <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
Colin Ian King authored and vinodkoul committed Jul 21, 2020
1 parent 783f6d3 commit 3d7b0ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)

if (device_property_read_u32(&pdev->dev, "qcom,tx-deamp_3_5db",
&phy_dwc3->tx_deamp_3_5db))
phy_dwc3->rx_eq = SSPHY_TX_DEEMPH_3_5DB;
phy_dwc3->tx_deamp_3_5db = SSPHY_TX_DEEMPH_3_5DB;

if (device_property_read_u32(&pdev->dev, "qcom,mpll", &phy_dwc3->mpll))
phy_dwc3->mpll = SSPHY_MPLL_VALUE;
Expand Down

0 comments on commit 3d7b0ca

Please sign in to comment.