Skip to content

Commit

Permalink
selftests/bpf: Make netcnt selftests serial to avoid spurious failures
Browse files Browse the repository at this point in the history
When running `./test_progs -j` test_netcnt fails with a very high
probability, undercounting number of packets received (9999 vs expected
10000). It seems to be conflicting with other cgroup/skb selftests. So
make it serial for now to make parallel mode more robust.

Signed-off-by: Andrii Nakryiko <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
  • Loading branch information
anakryiko authored and borkmann committed Nov 3, 2021
1 parent 7e5ad81 commit 401a33d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/bpf/prog_tests/netcnt.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#define CG_NAME "/netcnt"

void test_netcnt(void)
void serial_test_netcnt(void)
{
union percpu_net_cnt *percpu_netcnt = NULL;
struct bpf_cgroup_storage_key key;
Expand Down

0 comments on commit 401a33d

Please sign in to comment.